Skip to content

Adds link to debug token. #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Adds link to debug token. #354

merged 1 commit into from
Nov 18, 2019

Conversation

dbrumann
Copy link

@dbrumann dbrumann commented Aug 12, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

If a response contains a header X-Debug-Token-Link, i.e. a link to a Symfony debug toolbar profiler page, a clickable link is added to easily navigate to it.

Why?

This is purely for a more convenient debugging when investigating Responses from a (different) Symfony application.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@dbrumann
Copy link
Author

Made a few small changes. Here is an example screenshot:
Screenshot 2019-08-12 at 21 39 42

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! only thing left imho is to make the new code clean php 7.1 with static type hints, and add a note to the changelog.

@dbu
Copy link
Collaborator

dbu commented Aug 13, 2019

can you please add the changelog entry? i think otherwise we are good to merge.

@dbrumann
Copy link
Author

Yes, I will update the PR later this afternoon, including the changelog entry.

@dbu dbu merged commit 80ce05a into php-http:master Nov 18, 2019
@dbu
Copy link
Collaborator

dbu commented Nov 18, 2019

totally missed that you had updated this. thanks, nice feature!

@dbrumann dbrumann deleted the profiler_token_link branch November 18, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants